working lambda editor

src/css/editor.css

@@ -2,7 +2,7 @@
 
 .code {
   width: 100%;
-  font-size: 1.5rem;
+  font-size: 1.25rem;
 }
 
 .syntax-error {

src/css/modal.css

@@ -22,7 +22,7 @@
   margin: auto;
   padding: 20px;
   border: 1px solid var(--yellow);
-  width: 40%;
+  width: 60%;
   box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2);
   animation: scaleUp 0.25s;
   border-radius: 8px;

src/css/style.css

@@ -1,6 +1,7 @@
 @import url("./theme.css");
 @import url("./tf.css");
 @import url("./modal.css");
+@import url("./editor.css");
 
 @font-face {
   font-family: "scientifica";
@@ -95,10 +96,6 @@ a:visited {
   margin: 0;
 }
 
-.code {
-  width: 100%;
-}
-
 button {
   padding: 0.5rem;
   border: none;
@@ -108,12 +105,6 @@ button {
   cursor: pointer;
   transition: background 0.2s ease-in-out;
 }
-
 button:hover {
   background-color: var(--blue);
 }
-
-.syntax-error {
-  color: var(--red);
-  background-color: var(--yellow);
-}

src/engine/entities/LambdaFactory.ts

@@ -35,6 +35,9 @@ import { parse } from "../../interpreter";
 interface CodeEditorState {
   view: EditorView;
   editorElement: HTMLElement;
+  syntaxError: HTMLElement;
+  canvas: HTMLCanvasElement;
+  closeButton: HTMLButtonElement;
 }
 
 const highlightEffect = StateEffect.define<Range<Decoration>[]>();
@@ -54,12 +57,16 @@ const highlightExtension = StateField.define({
   },
   provide: (f) => EditorView.decorations.from(f),
 });
+
 const FontSizeTheme = EditorView.theme({
   $: {
-    fontSize: "20pt",
+    fontSize: "16pt",
   },
 });
 const FontSizeThemeExtension: Extension = [FontSizeTheme];
+const syntaxErrorDecoration = Decoration.mark({
+  class: "syntax-error",
+});
 
 export class LambdaFactory extends Entity {
   private static spriteSpec: SpriteSpec = SPRITE_SPECS.get(
@@ -67,13 +74,11 @@ export class LambdaFactory extends Entity {
   ) as SpriteSpec;
 
   private codeEditorState: CodeEditorState | null;
-  private code: string;
   private spawns: number;
 
   constructor(gridPosition: Coord2D, code: string, spawns: number) {
     super(EntityNames.LambdaFactory);
 
-    this.code = code;
     this.spawns = spawns;
     this.codeEditorState = null;
 
@@ -95,7 +100,7 @@ export class LambdaFactory extends Entity {
 
     this.addComponent(new Colliding());
 
-    this.addComponent(new LambdaSpawn(this.spawns, this.code));
+    this.addComponent(new LambdaSpawn(this.spawns, code));
 
     this.addComponent(new Grid(gridPosition));
 
@@ -134,39 +139,79 @@ export class LambdaFactory extends Entity {
     this.addComponent(text);
   }
 
-  private onHighlight(direction: Direction) {
+  private openCodeEditor() {
-    if (direction === Direction.LEFT || direction === Direction.RIGHT) {
+    const modalContent =
-      this.addComponent(new Interactable(() => this.spawnNewLambda(direction)));
+      "<div class='code'><div id='code'></div><br><p id='syntax-error' class='error'></p><button id='close-modal'>Save</button></div>";
-      return;
+    openModal(modalContent);
-    }
 
-    let modalOpen = false;
+    const { code } = this.getComponent<LambdaSpawn>(ComponentNames.LambdaSpawn);
-    let editorView: EditorView | null = null;
+    const startState = EditorState.create({
-
+      doc: code,
-    const syntaxErrorDecoration = Decoration.mark({
+      extensions: [
-      class: "syntax-error",
+        basicSetup,
+        keymap.of(defaultKeymap),
+        rainbowBrackets(),
+        highlightExtension,
+        FontSizeThemeExtension,
+      ],
     });
 
-    const close = () => {
+    const codeBox = document.getElementById("code")!;
-      if (editorView) {
+    const syntaxError = document.getElementById("syntax-error")!;
-        const text = editorView.state.doc.toString();
+    const canvas = document.getElementById(
+      Miscellaneous.CANVAS_ID,
+    ) as HTMLCanvasElement;
+    const closeButton = document.getElementById(
+      "close-modal",
+    ) as HTMLButtonElement;
+    closeButton.addEventListener("click", () => this.saveAndCloseCodeEditor());
 
-        // remove all text from the editor
+    const editorView = new EditorView({
-        editorView.dispatch({
+      state: startState,
+      parent: codeBox,
+    });
+    editorView.focus();
+
+    this.codeEditorState = {
+      view: editorView,
+      editorElement: codeBox,
+      syntaxError,
+      canvas,
+      closeButton,
+    };
+  }
+
+  private refreshCodeEditorText(text: string) {
+    if (!this.codeEditorState) {
+      return;
+    }
+    const { view } = this.codeEditorState;
+
+    view.dispatch({
       changes: {
         from: 0,
         to: text.length,
         insert: "",
       },
     });
-        // add the new text to the editor
+    view.dispatch({
-        editorView.dispatch({
       changes: {
         from: 0,
         to: 0,
         insert: text,
       },
     });
+  }
+
+  private saveAndCloseCodeEditor() {
+    if (!this.codeEditorState) {
+      return;
+    }
+
+    const { canvas, view, editorElement, syntaxError } = this.codeEditorState;
+    const text = view.state.doc.toString();
+    this.refreshCodeEditorText(text);
+    syntaxError.innerText = "";
 
     try {
       parse(text);
@@ -181,68 +226,41 @@ export class LambdaFactory extends Entity {
         },
       } = e;
 
-          editorView.dispatch({
+      view.dispatch({
         effects: highlightEffect.of([
-              syntaxErrorDecoration.range(
+          syntaxErrorDecoration.range(start === end ? start - 1 : start, end),
-                start === end ? start - 1 : start,
-                end,
-              ),
         ]),
       });
 
-          document.getElementById("syntax-error")!.innerText = e.message;
+      syntaxError.innerText = e.message;
-
       return;
     }
 
-        const spawner = this.getComponent<LambdaSpawn>(
+    const spawner = this.getComponent<LambdaSpawn>(ComponentNames.LambdaSpawn);
-          ComponentNames.LambdaSpawn,
-        );
     spawner.code = text;
     this.addComponent(spawner);
-      }
 
-      modalOpen = false;
+    view.destroy();
+    editorElement.innerHTML = "";
+    this.codeEditorState = null;
     closeModal();
 
-      document.getElementById(Miscellaneous.CANVAS_ID)!.focus();
+    canvas.focus();
-      return;
+  }
-    };
 
-    const interaction = () => {
+  private onHighlight(direction: Direction) {
-      if (modalOpen) {
+    if (direction === Direction.LEFT || direction === Direction.RIGHT) {
-        close();
+      this.addComponent(new Interactable(() => this.spawnNewLambda(direction)));
       return;
     }
-      modalOpen = true;
 
-      openModal(
+    const interaction = () => {
-        "<div class='code'><div id='code'></div><br><p id='syntax-error' class='error'></p><button id='close-modal'>Save</button></div>",
+      if (this.codeEditorState) {
-      );
+        this.saveAndCloseCodeEditor();
-      const spawner = this.getComponent<LambdaSpawn>(
+        return;
-        ComponentNames.LambdaSpawn,
+      }
-      );
 
-      const startState = EditorState.create({
+      this.openCodeEditor();
-        doc: spawner.code,
-        extensions: [
-          basicSetup,
-          keymap.of(defaultKeymap),
-          rainbowBrackets(),
-          highlightExtension,
-          FontSizeThemeExtension,
-        ],
-      });
-
-      const codeBox = document.getElementById("code")!;
-      editorView = new EditorView({
-        state: startState,
-        parent: codeBox,
-      });
-
-      editorView.focus();
-
-      document.getElementById("close-modal")!.addEventListener("click", close);
     };
 
     this.addComponent(new Interactable(interaction));